Move approval into a separate button from shield #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for earnest-cascaron-03dbfc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mds1
reviewed
Jan 17, 2023
alexkeating
changed the title
mds1
reviewed
Jan 17, 2023
alexkeating
force-pushed
the
feature/confirmation-modal
branch
from
e068fe1 to
ced2e67
Compare
mds1
reviewed
Jan 19, 2023
mds1
approved these changes
Jan 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did this as a part of #17. Before creating the shield review modal it made sense to have an approval button, and add the review modal that pops up after approval. Instead of doing an approval on every transaction we fetch the allowances on loading of the app and check whether the token needs approval.