Fix lintr warnings

R/sg_palette.R

@@ -5,9 +5,9 @@
 #' reversed.
 #' @param colour_names Boolean value to indicate whether colour names should be
 #' included.
-#' @param palette_type Either `sg` to use Scottish Government palettes, `sss`
-#' to use Social Security Scotland palettes or `af` to use Analysis Function
-#' palettes. Defaults to `sg`.
+#' @param palette_type Either "sg" to use Scottish Government palettes
+#' (default), "sss" to use Social Security Scotland palettes or "af" to use
+#' Analysis Function palettes.
 #'
 #' @noRd
 
@@ -31,7 +31,7 @@ sg_palette <- function(palette = "main",
   if (!palette %in% names(palette_list)) {
     cli::cli_abort(
       c("x" = paste("{.str {palette}} is not a valid palette name ",
-                  "for {.str {palette_type}} palette type."),
+                    "for {.str {palette_type}} palette type."),
         "i" = "Available palette{?s}: {.str {names(palette_list)}}."),
       call = error_call
     )

R/use_sgplot.R

@@ -50,7 +50,7 @@ use_sgplot <- function(default_colour = sgplot::sg_colour_values["dark-blue"],
 
   # Update default values with those passed to use_sgplot
   new_values <- c(...)
-  for (i in 1:length(new_values)) {
+  for (i in seq_along(new_values)) {
     default <- replace(default,
                        which(names(default) == names(new_values)[i]),
                        new_values[i])