Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop sending full defences on low levels #844

Merged
merged 43 commits into from
Mar 12, 2024
Merged

Stop sending full defences on low levels #844

merged 43 commits into from
Mar 12, 2024

Commits on Feb 23, 2024

  1. defences undefined for levels 1 and 2

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7bedff7 View commit details
    Browse the repository at this point in the history

  2. fixes tests

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7e86ae4 View commit details
    Browse the repository at this point in the history

  3. propoerly undefines defences on level 1 and 2

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b0a4823 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. moves variable declarations to destructureing

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4e45d90 View commit details
    Browse the repository at this point in the history

  2. missed one

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d92314c View commit details
    Browse the repository at this point in the history

  3. undo error swallow

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    74d8fb4 View commit details
    Browse the repository at this point in the history

  4. merge dev

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1237cca View commit details
    Browse the repository at this point in the history

  5. remove bad type guards

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    dc66ffb View commit details
    Browse the repository at this point in the history

  6. improve validation for configureDefence

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c442d04 View commit details
    Browse the repository at this point in the history

  7. last bit of validation

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    aa8f672 View commit details
    Browse the repository at this point in the history

  8. update tests for handleConfigureDefence

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    aa0c576 View commit details
    Browse the repository at this point in the history

  9. new folder for defence controller unit tests and wrote first handleDe… 

    …fencecActivation test
    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d6b6455 View commit details
    Browse the repository at this point in the history

  10. adds test for defence activation

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    294de45 View commit details
    Browse the repository at this point in the history

  11. adds tests for defence deactivation

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4785161 View commit details
    Browse the repository at this point in the history

  12. moves tests all back into one file again

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    66cdd2e View commit details
    Browse the repository at this point in the history

  13. adds tests for handleResetSingleDefence

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e74a26f View commit details
    Browse the repository at this point in the history

  14. improve validation on handleGetDefenceStatus

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    663b22e View commit details
    Browse the repository at this point in the history

  15. removes extraneous stuff from test objects

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8429bfd View commit details
    Browse the repository at this point in the history

  16. adds tests to make sure defences aren't chngeable for level 1

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ebba951 View commit details
    Browse the repository at this point in the history

  17. add loop to test levels 1 and 2 with same code

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    107e453 View commit details
    Browse the repository at this point in the history

  18. adds remaining tests for defence controller integration

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    373e0b7 View commit details
    Browse the repository at this point in the history

  19. handleResetSingleDefence takes level parameter now

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8293a4a View commit details
    Browse the repository at this point in the history

  20. adds level to frontend call to reset defence config item. Types all t… 

    …he prop drillings properly
    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ae5e746 View commit details
    Browse the repository at this point in the history

  21. some renamings and fill in gaps in tests

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a336617 View commit details
    Browse the repository at this point in the history

  22. adds another missing test

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    23771d9 View commit details
    Browse the repository at this point in the history

  23. tweaks

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2aab5f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. merge dev

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a04ca87 View commit details
    Browse the repository at this point in the history

  2. fix test suite

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    24b7c04 View commit details
    Browse the repository at this point in the history

  3. replace defence search with defences.some and replace cuurrentDefence… 

    …s === undefined check with not currentDefences
    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2fc5a6f View commit details
    Browse the repository at this point in the history

  4. change defenceId for generic falsy check

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e907b04 View commit details
    Browse the repository at this point in the history

  5. improve guards for level and config

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f56383f View commit details
    Browse the repository at this point in the history

  6. improve guards for level and config

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    65b5644 View commit details
    Browse the repository at this point in the history

  7. correct test for configuring a config item

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b45cce9 View commit details
    Browse the repository at this point in the history

  8. updates error message when not allowed to activate or modify defences

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d670f00 View commit details
    Browse the repository at this point in the history

  9. rescturecure defence controller integration tests

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    095ad15 View commit details
    Browse the repository at this point in the history

  10. change other tests to use test.each rather than foreach

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0d02968 View commit details
    Browse the repository at this point in the history

  11. uses isValidLevel

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9f9d628 View commit details
    Browse the repository at this point in the history

  12. improve validateFilterConfig

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dec9904 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. just pass qa defence rather than all defences

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e98c251 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b0e17d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. uses type intersection to define QaLlmDefence

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    360c30c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into stop-sending-full-defences-on-low-leevels

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    600dc65 View commit details
    Browse the repository at this point in the history

  3. only gedDefencesFrDTOs if it is defined

    @pmarsh-scottlogic
    pmarsh-scottlogic committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8ec48c7 View commit details
    Browse the repository at this point in the history