-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
80 configure email whitelist defence #85
Closed
heatherlogan-scottlogic
wants to merge
13
commits into
dev
from
80-configure-email-whitelist-defence
Closed
80 configure email whitelist defence #85
heatherlogan-scottlogic
wants to merge
13
commits into
dev
from
80-configure-email-whitelist-defence
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/gsproston-scottlogic/prompt-injection into 73-configure-character-limit-defence
heatherlogan-scottlogic
requested review from
gsproston-scottlogic and
scottrowan
August 3, 2023 09:16
gsproston-scottlogic
suggested changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one change from me
backend/src/email.js
Outdated
Comment on lines
1
to
2
const { getEmailWhitelistVar } = require("./defence.js"); | ||
const { isDefenceActive } = require("./defence"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge these two imports as they're coming from the same file
Closed
Should merge this after #76 is merged |
Covered by #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.