645 streamline network calls for resetting level progress #872
Conversation
backend/src/sessionRoutes.ts
Outdated
|
|
||
| // model configurations | ||
| router.post('/openai/model', handleSetModel); | ||
| router.post('/openai/model/configure', handleConfigureModel); | ||
|
|
||
| // reset progress for all levels | ||
| router.post('/reset', handleResetProgress); | ||
| router.post('/resetlevel', handleResetLevel); |
There was a problem hiding this comment.
I was thinking of something like this for the endpoints. Originally I considered a path param for reset level, but it didn't seem quite right, plus this is nice as it's consistent:
POST /restart?currentLevel=N
POST /reset?level=N
I also note that the /level endpoint seems a touch redundant, and could definitely use a path param, but that's a separate matter.
GET /level?level=1
vs
GET /level/1
There was a problem hiding this comment.
I dislike using restart and reset to distinguish between resetting the whole game and resetting a single level - think it should be spelled out which does which. I'm also keen to keep the language consistent with the frontend.
happy with other alternatives that do this. e.g:
POST /resetall?currentLevel=N
POST /reset?level=N
POST /reset/all?currentlLevel=N
POST /reset?level=n
There was a problem hiding this comment.
Well, there's little difference between resetall and reset and restart, so it's going to be confusing whichever of these we would pick...
How about "resetgame" or similar?
Alternatively, we could use my initial thought about using a path param combined with yours for reset all:
POST /reset/all?currentLevel=N
POST /reset/{level}
Then it comes down to making it work in Express; likely we need them defined in the above order, so that express looks for "all" before trying a path param for level.
There was a problem hiding this comment.
yeah I like this. Done
pmarsh-scottlogic
deleted the
645-streamline-network-calls-for-resetting-level-progress
branch
Description
Here's what happens when you used to reset level progress:
openai/clearclears the chat history for given level.email/clearclears the emails for given level.openai/addHistoryadds the "Level progress reset" info message to given level's chat historyNow we just have
resetlevelwhich clears the chat history and emails of current level and returns the resulting intochatMessageScreenshots
Notes
resetlevelendpoint, and related service methods and modelsemail/clearendpoint (and therefore the whole email controller and email service and related models)openai/clearendpoint (and related service and model code)StartResponseConcerns
{resultingChatInfoMessage: //}. I think it's better to make it clear what this message is by giving it a name in the response.Checklist
Have you done the following?