828 streamline chat model configuration info message network call #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
reviewed
Mar 25, 2024
chriswilty
reviewed
Mar 26, 2024
| @@ -39,6 +31,10 @@ const modelConfigIds = [ | |||
|
|
|||
| type MODEL_CONFIG_ID = (typeof modelConfigIds)[number]; | |||
|
|
|||
| type ChatModelConfigurations = { | |||
There was a problem hiding this comment.
There must be a reason you pluralised this, right? Is there a clash with another type, or did you feel it made more sense as a plural? Or did you do so to match the frontend code?
There was a problem hiding this comment.
I prefer it that way.
If each of top p, `frequency penalty etc are one configuration, then the set of all of them should be called configurations.
There was a problem hiding this comment.
That's fine, but then export it as that - currently you're exporting it as ChatModelConfiguration.
chriswilty
reviewed
Mar 26, 2024
chriswilty
approved these changes
Mar 26, 2024
chriswilty
requested changes
Mar 27, 2024
| @@ -39,6 +31,10 @@ const modelConfigIds = [ | |||
|
|
|||
| type MODEL_CONFIG_ID = (typeof modelConfigIds)[number]; | |||
|
|
|||
| type ChatModelConfigurations = { | |||
There was a problem hiding this comment.
That's fine, but then export it as that - currently you're exporting it as ChatModelConfiguration.
pmarsh-scottlogic
deleted the
828-streamline-chat-model-configuration-info-message-network-call
branch
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, when the user would configure the chatModel, we would send a request to the backend. If the backend successfully configured the model, then the frontend would send a further request to add the info message to the chat history, eg 'changed frequencyPenalty to 0.6'.
This PR changes it so that when the backend successfully configures the chatModel, the backend generates the info message and appends it to the history, then forwards it on to the frontend.
Notes
handleConfigureModelnow generates an info message, appends it to the chat history and forwards it to the frontend.MODEL_CONFIGenum toMODEL_CONFIG_IDand converts it to a string literal type, on frontend and backend.handleConfigureModel.handleConfigureModel.Checklist
Have you done the following?