Prepare for release 1.0.3 #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
commented
Jul 15, 2024
| const updatedDefence = req.session.levelState[level].defences.find( | ||
| (defence) => defence.id === defenceId | ||
| ); | ||
| if (!updatedDefence) { |
There was a problem hiding this comment.
Change here is a result of eslint pointing out that updatedDefences in original code could not actually be undefined.
chriswilty
commented
Jul 15, 2024
| @@ -50,7 +49,7 @@ describe('DocumentViewBox component tests', () => { | |||
|
|
|||
| const mockDocumentViewer = vi.hoisted(() => vi.fn()); | |||
| vi.mock('@cyntler/react-doc-viewer', () => ({ | |||
| default: (props: DocViewerProps) => { | |||
There was a problem hiding this comment.
DocViewerProps is no longer available as an export in the latest release, but in any case, in the cloud feature branch I've changed the test to render the actual DocViewer component, instead of mocking it, so soon enough this code will be removed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #917
Checklist
Have you done the following?