feat(action): Verify no matching cache before save

Prior to saving cache, verify that there is no cache with a matching key
already cached. Previously, we checked if a cache key matching our cache
was present in the load step; if not, we would then proceed to save the
cache in the save step (assuming we were not in read-only mode and that
there were indeed new Docker images to save). This is problematic if
the action is being run in parallel for multiple jobs; in that case,
there could be multiple, unnecessary cache saves if the cache initially
misses but is subsequently saved.

src/docker.test.ts

@@ -87,14 +87,15 @@ describe("Docker images", (): void => {
   const assertSaveDockerImages = (
     cacheHit: boolean,
     readOnly = false,
+    prevSave = false,
   ): void => {
     expect(core.getInput).nthCalledWith<[string, InputOptions]>(1, "key", {
       required: true,
     });
     expect(core.getState).nthCalledWith<[string]>(1, docker.CACHE_HIT);
     if (!cacheHit) {
       expect(core.getInput).lastCalledWith("read-only");
-      if (!readOnly) {
+      if (!readOnly && !prevSave) {
         expect(core.getState).lastCalledWith(docker.DOCKER_IMAGES_LIST);
         expect(core.info).nthCalledWith<[string]>(1, "Listing Docker images.");
         expect(util.execBashCommand).nthCalledWith<[string]>(
@@ -109,6 +110,7 @@ describe("Docker images", (): void => {
     key: string,
     cacheHit: boolean,
     readOnly: boolean,
+    prevSave: boolean,
     preexistingImages: string[],
     newImages: string[],
   ): Promise<void> => {
@@ -117,14 +119,19 @@ describe("Docker images", (): void => {
     if (!cacheHit) {
       core.getInput.mockReturnValueOnce(readOnly.toString());
       if (!readOnly) {
-        core.getState.mockReturnValueOnce(preexistingImages.join("\n"));
-        const images = preexistingImages.concat(newImages);
-        util.execBashCommand.mockResolvedValueOnce(images.join("\n"));
+        if (prevSave) {
+          cache.restoreCache.mockResolvedValueOnce(key);
+        } else {
+          cache.restoreCache.mockResolvedValueOnce(key + "make keys mismatch");
+          core.getState.mockReturnValueOnce(preexistingImages.join("\n"));
+          const images = preexistingImages.concat(newImages);
+          util.execBashCommand.mockResolvedValueOnce(images.join("\n"));
+        }
       }
     }
     await docker.saveDockerImages();
 
-    assertSaveDockerImages(cacheHit, readOnly);
+    assertSaveDockerImages(cacheHit, readOnly, prevSave);
   };
 
   const assertCacheNotSaved = (): void => {
@@ -147,6 +154,15 @@ describe("Docker images", (): void => {
     assertCacheNotSaved();
   };
 
+  const assertSavePrevSave = (): void => {
+    expect(core.info).lastCalledWith(
+      "A cache miss occurred in loadDockerImages; subsequently a cache with " +
+        "a matching key was saved. This can occur when docker-cache is used by " +
+        "multiple jobs run in parallel. Not saving cache.",
+    );
+    assertCacheNotSaved();
+  };
+
   const assertNoNewImagesToSave = (): void => {
     expect(util.execBashCommand).toHaveBeenCalledTimes(1);
     expect(core.info).lastCalledWith("No Docker images to save");
@@ -230,24 +246,29 @@ describe("Docker images", (): void => {
   );
 
   testProp(
-    "are saved unless cache hit, in read-only mode, or new Docker image list is empty",
+    "are saved unless cache hit, in read-only mode, a previous save occurs on " +
+      "the same cache key between loadDockerImages and saveDockerImages or new " +
+      "Docker image list is empty",
     [
       fullUnicodeString(),
       boolean(),
       boolean(),
+      boolean(),
       uniquePair(dockerImages(), dockerImages()),
     ],
     async (
       key: string,
       cacheHit: boolean,
       readOnly: boolean,
+      prevSave: boolean,
       [preexistingImages, newImages]: [string[], string[]],
     ): Promise<void> => {
       jest.clearAllMocks();
       await mockedSaveDockerImages(
         key,
         cacheHit,
         readOnly,
+        prevSave,
         preexistingImages,
         newImages,
       );
@@ -256,6 +277,8 @@ describe("Docker images", (): void => {
         assertSaveCacheHit(key);
       } else if (readOnly) {
         assertSaveReadOnly(key);
+      } else if (prevSave) {
+        assertSavePrevSave();
       } else if (newImages.length === 0) {
         assertNoNewImagesToSave();
       } else {
@@ -264,10 +287,14 @@ describe("Docker images", (): void => {
     },
     {
       examples: [
-        ["my-key", false, false, [["preexisting-image"], ["new-image"]]],
-        ["my-key", false, false, [["preexisting-image"], []]],
-        ["my-key", false, true, [["preexisting-image"], ["new-image"]]],
-        ["my-key", true, false, [["preexisting-image"], ["new-image"]]],
+        ["my-key", false, false, false, [["preexisting-image"], ["new-image"]]],
+        ["my-key", false, false, false, [["preexisting-image"], []]],
+        ["my-key", false, true, false, [["preexisting-image"], ["new-image"]]],
+        ["my-key", true, false, false, [["preexisting-image"], ["new-image"]]],
+        ["my-key", false, false, true, [["preexisting-image"], ["new-image"]]],
+        ["my-key", false, false, true, [["preexisting-image"], []]],
+        ["my-key", false, true, true, [["preexisting-image"], ["new-image"]]],
+        ["my-key", true, false, true, [["preexisting-image"], ["new-image"]]],
       ],
     },
   );

src/docker.ts

@@ -36,6 +36,17 @@ const saveDockerImages = async (): Promise<void> => {
       `Cache miss occurred on the primary key ${key}. Not saving cache as ` +
         "read-only option was selected.",
     );
+    /* Check if a cache with our key has been saved between when we checked in
+     * loadDockerImages and now.
+     */
+  } else if (
+    key === (await restoreCache([""], key, [], { lookupOnly: true }))
+  ) {
+    info(
+      "A cache miss occurred in loadDockerImages; subsequently a cache with " +
+        "a matching key was saved. This can occur when docker-cache is used by " +
+        "multiple jobs run in parallel. Not saving cache.",
+    );
   } else {
     const preexistingImages = getState(DOCKER_IMAGES_LIST).split("\n");
     info("Listing Docker images.");