feat: allow for usage of skip while using DerivePartialModel (analagous to FromQueryResult)
#2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreppnow
changed the title
skip while using DerivePartialModel (analagous to FromQueryResult)
4 tasks
billy1624
reviewed
May 2, 2024
There was a problem hiding this comment.
Hey @jreppnow, thanks for contributing!! I have some suggested changes!
Please check if that make sense to you :)
pol-inc/sea-orm@feat/reppnj/partial-model-skip...billy1624:pr/2167
|
@jreppnow can you merge @billy1624 's patch? |
|
@tyt2y3 @billy1624 Sorry for the delay - merged the suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
skipwhen derivingPartialModelTrait, analogous toFromQueryResultChanges