Improvements for Web Components

[marschall]

Improvements that allow applications with Web Components to run with a lower overhead.

• Save only a single action continuation. Since the back button does not work with Web Components in general we only need to save a single action continuation. This should keep sessions smaller.
• Dedicated action continuation. Since the back button does not work with Web Components in general we can make use of an optimized action continuation that:
  • does not redirect.
  • does not capture state.
  • does not restore state.

In theory these classes could be used in general for "back button less" Seaside applications. However this is quite an advanced topic so I think it's ok to "burry" these in the WebComponents package. Let me know what you think.

[codecov]

Codecov Report

Attention: Patch coverage is 75.70093% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.03%. Comparing base (0f7d6f7) to head (f6be4f2).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...age/WASingleElementCache.class/instance/remove..st	0.00%	5 Missing ⚠️
...nContinuation.class/instance/basicPerformAction.st	0.00%	4 Missing ⚠️
...onentActionContinuation.class/instance/continue.st	0.00%	4 Missing ⚠️
...nSession.class/instance/createContinuationCache.st	0.00%	3 Missing ⚠️
...ActionContinuation.class/instance/jumpToAnchor..st	0.00%	3 Missing ⚠️
...tActionContinuation.class/instance/restoreState.st	0.00%	3 Missing ⚠️
...ctionContinuation.class/instance/shouldRedirect.st	0.00%	3 Missing ⚠️
...tsLibrary.class/instance/seasideWebComponentsJs.st	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   49.42%   50.03%   +0.61%     
==========================================
  Files        9073     8946     -127     
  Lines       80086    79229     -857     
==========================================
+ Hits        39582    39645      +63     
+ Misses      40504    39584     -920     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adriaon]

Is there a typo or two in https://github.com/marschall/Seaside/blob/master/repository/Seaside-WebComponents-Core.package/WAHeadlessComponent.class/README.md ?

Also, I wouldn't mind if the classes that are useful for SPA's are not buried, but more generally available. Perhaps in a SPA package?

[marschall]

Is there a typo or two in https://github.com/marschall/Seaside/blob/master/repository/Seaside-WebComponents-Core.package/WAHeadlessComponent.class/README.md ?

Probably a rendering issue by GitHub. Check out the raw content

https://raw.githubusercontent.com/marschall/Seaside/refs/heads/master/repository/Seaside-WebComponents-Core.package/WAHeadlessComponent.class/README.md

Also, I wouldn't mind if the classes that are useful for SPA's are not buried, but more generally available. Perhaps in a SPA package?

What classes would you be interested in? WAWebComponentActionContinuation? Do you have a suggestion for a name?

Perhaps in a SPA package?

Maybe, but only if we have more than one class to go there.

[adriaon]

https://raw.githubusercontent.com/marschall/Seaside/refs/heads/master/repository/Seaside-WebComponents-Core.package/WAHeadlessComponent.class/README.md

Got it. Thanks

What classes would you be interested in? WAWebComponentActionContinuation? Do you have a suggestion for a name?

Perhaps in a SPA package?

Maybe, but only if we have more than one class to go there.

If I understand things correctly, i see

• WAWebComponentActionContinuation
• WASingleElementCache
• WASingleContinuationSession

as candidates.

Maybe something like Seaside-SingleContinuation-Core as a name? Or maybe rename Seaside-WebComponents-Core as such?

Cheers,
Adriaan.

[jbrichau]

Looks good to me. Thanks for this!
I made a couple of code style suggestions in the detail comments.

I was first expecting a "single continuation session" to always reuse the same continuation, like what happens with ajax requests. I do a similar thing in WATurboRenderPhaseContinuation. However, I now realise that because the webcomponent re-renders its entire fragment, it's better to throw away the old rendercontext and indeed create an entire new continuation.

[jbrichau]

Side-note: since we do not capture state, do we need the contents of the states instvar in this class?

[marschall]

I see what you meant. The question comes down to how much we want to tie WAFragmentRenderPhaseContinuation to WAFragmentRenderPhaseContinuation. Right now the states inst vars are still filled with WASnapshot instances due to two reasons:

• WAFragmentRenderPhaseContinuation inheritsWARenderLoopContinuation >> #createActionContinuationWithContext: and send #snapshot:renderContext: to the action phase continuation class
• WAWebComponentActionContinuation >> #handle: still sends ends up in WASessionContinuation >> #handle:

[jbrichau]

It was not a blocking comment but maybe something to look at further down the road.

[marschall]

Added responses to review comments