fix(docs): add note that Basic tier in Event Hub does not support Kafka protocol #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
reviewed
Jul 12, 2023
docs/source/contents/getting-started/kubernetes-installation/security/azure-event-hub-sasl.md
Outdated
Show resolved
Hide resolved
agrski
reviewed
Jul 12, 2023
| @@ -4,9 +4,13 @@ | |||
|
|
|||
| Seldon Core v2 can integrate with Azure Event Hub via Kafka protocol. | |||
|
|
|||
| ```{warning} | |||
| You will need at least `Standard` tier for your Event Hub Namespace as `Basic` tier does not support Kafka protocol. | |||
| ``` | |||
There was a problem hiding this comment.
💭 Having two warning blocks after one another is a bit noisy visually. A single block with two paragraphs would be easier to read.
There was a problem hiding this comment.
These are only semi related so I should leave them independent as they provide separate bits of informations.
…ecurity/azure-event-hub-sasl.md Co-authored-by: Alex Rakowski <20504869+agrski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: