Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): consistent pod service monitors reconcilor app labels #5073

Conversation

michaelcheah
Copy link
Contributor

What this PR does / why we need it:
The default matchLabel configs for Prometheus podmonitors do not match what is configured by the SeldonRuntime operator for several resources.

This PR:

  1. Fixes the labels so that they are consistent across all resources, i.e. all label use app.kubernetes.io/name key instead of app to reference seldon components
  2. The component name seldon-mesh is outdated and is updated to seldon-envoy.
  3. The server metrics port for the default mlserver is not defined (it is defined for the triton server). We expose it on port 8082 which is the default for mlserver

Which issue(s) this PR fixes:
Fixes #5071

Special notes for your reviewer:

@michaelcheah michaelcheah changed the title Bugfix consistent pod service monitors reconcilor app labels bugfix(operator): consistent pod service monitors reconcilor app labels Aug 9, 2023
@michaelcheah michaelcheah changed the title bugfix(operator): consistent pod service monitors reconcilor app labels fix(operator): consistent pod service monitors reconcilor app labels Aug 9, 2023
@RafalSkolasinski RafalSkolasinski merged commit 00c2b3b into SeldonIO:v2 Aug 10, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants