fix(podmonitor): Pipelinegateway podmonitor label fix #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherrymu
changed the title
ChewieSC
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
I tested this in Deploy - this fixes the requests not showing for Core v2 pipelines on the dashboard page (plus the graphs below were also empty).
But mb wait with merge for @RafalSkolasinski to approve as well.
RafalSkolasinski
approved these changes
Sep 5, 2023
RafalSkolasinski
pushed a commit
that referenced
this pull request
Sep 7, 2023
* corrected pipelinegateway podmonitor label * Revert "corrected pipelinegateway podmonitor label" This reverts commit 1846876. * corrected pipelinegateway podmonitor label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This will align with the correct labels that pipeline gateway pod contains and metrics will be scrapped
Which issue(s) this PR fixes:
Fixes #5071
Special notes for your reviewer: