Added new React frontend challenge #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
23d1118
|
| Status: | 🚫 Build failed. |
json formatting for example json
stephanLe
reviewed
Sep 19, 2023
| 3. Delete a project | ||
| 4. Display all projects | ||
| 5. Create a new task for an existing project with a project_id, name, description and status. The status is set to OPEN by default. | ||
| 6. Edit name, description and status of a task |
There was a problem hiding this comment.
These are two separate functionalities - edit the name & description (most likely in some kind of edit dialog) and change the status (drag & drop in a Kanban board).
stephanLe
reviewed
Sep 19, 2023
|
|
||
| ## What has already been implemented for you ✅ | ||
|
|
||
| The backend uses Hasura to create an API, Postgres as a database, |
There was a problem hiding this comment.
Maybe add an architecture diagram to visualize this.
stephanLe
reviewed
Sep 19, 2023
| GraphQL for the requests and Cloudflare workers to generate JWTs (https://jwt.io/introduction) needed for authorization. | ||
|
|
||
|
|
||
| Each project is exclusively mapped to a single user through their email-address. By that, the respective tasks are restricted to the creator of the project as well. |
There was a problem hiding this comment.
Add comment that therefore, users cannot access tasks of other users.
stephanLe
reviewed
Sep 19, 2023
| This token has to be included in the request header of each GraphQL query/mutation. Else, access will be denied. 😈 | ||
|
|
||
| The requests have to be sent to this URL: https://react-challenge.deploy.selectcode.dev/v1/graphql. | ||
| One of the header titles of each request must be set to "Authorization" and the value to "Bearer < JWT > ". |
There was a problem hiding this comment.
Please include the example for test@selectcode.de.
stephanLe
reviewed
Sep 19, 2023
|
|
||
| export default { | ||
|
|
||
| async fetch(request: Request) { |
There was a problem hiding this comment.
Please add more documentation - how does an example JWT look at the end? How is the format of the input parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cloudflare worker for creating jwt's for future react frontend challenge.