Skip to content

Commit

Permalink
make error logging slightly more pleasant
Browse files Browse the repository at this point in the history
  • Loading branch information
toddtarsi committed Nov 17, 2023
1 parent 1f5aafd commit d1bcee7
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 15 deletions.
4 changes: 2 additions & 2 deletions packages/selenium-ide/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@
"@seleniumhq/code-export-ruby-rspec": "^4.0.0-alpha.1",
"side-code-export": "^4.0.0-alpha.11",
"@seleniumhq/get-driver": "^4.0.0-alpha.1",
"@seleniumhq/side-api": "^4.0.0-alpha.32",
"@seleniumhq/side-api": "^4.0.0-alpha.33",
"@seleniumhq/side-model": "^4.0.0-alpha.4",
"@seleniumhq/side-runtime": "^4.0.0-alpha.30",
"@seleniumhq/side-runtime": "^4.0.0-alpha.31",
"dnd-core": "^16.0.1",
"electron-chromedriver": "^26.4.0",
"electron-log": "^4.4.8",
Expand Down
4 changes: 2 additions & 2 deletions packages/side-api/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@seleniumhq/side-api",
"version": "4.0.0-alpha.32",
"version": "4.0.0-alpha.33",
"private": false,
"description": "Selenium IDE API command shapes and such",
"author": "Todd Tarsi <tarsitodd@gmail.com>",
Expand All @@ -20,7 +20,7 @@
"@seleniumhq/browser-info": "^4.0.0-alpha.1",
"@seleniumhq/get-driver": "^4.0.0-alpha.2",
"@seleniumhq/side-model": "^4.0.0-alpha.4",
"@seleniumhq/side-runtime": "^4.0.0-alpha.30",
"@seleniumhq/side-runtime": "^4.0.0-alpha.31",
"lodash": "^4.17.21"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/side-code-export/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"types": "dist/index.d.ts",
"dependencies": {
"@seleniumhq/side-model": "^4.0.0-alpha.4",
"@seleniumhq/side-runtime": "^4.0.0-alpha.30",
"@seleniumhq/side-runtime": "^4.0.0-alpha.31",
"commander": "^9.4.0"
},
"gitHead": "f58e327e7616e23a3e926e4b80cf9952164e5744"
Expand Down
2 changes: 1 addition & 1 deletion packages/side-example-suite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@seleniumhq/code-export-python-pytest": "4.0.0-alpha.2"
},
"devDependencies": {
"@seleniumhq/side-api": "^4.0.0-alpha.32"
"@seleniumhq/side-api": "^4.0.0-alpha.33"
},
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions packages/side-runner/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "selenium-side-runner",
"version": "4.0.0-alpha.59",
"version": "4.0.0-alpha.60",
"private": false,
"description": "Run Selenium IDE projects in cli",
"repository": "https://github.com/SeleniumHQ/selenium-ide",
Expand All @@ -24,7 +24,7 @@
"license": "Apache-2.0",
"dependencies": {
"@seleniumhq/side-model": "^4.0.0-alpha.4",
"@seleniumhq/side-runtime": "^4.0.0-alpha.30",
"@seleniumhq/side-runtime": "^4.0.0-alpha.31",
"commander": "^11.0.0",
"glob": "^10.3.1",
"jest": "^29.6.0",
Expand Down
4 changes: 4 additions & 0 deletions packages/side-runner/src/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ const buildRunners = ({ configuration, logger }: HoistedThings) => {
}`
)
if (state !== 'finished') {
logger.info(
'Last command:',
playback['state'].lastSentCommandState?.command
)
return onComplete(
playback['state'].lastSentCommandState?.error ||
new Error('Unknown error')
Expand Down
2 changes: 1 addition & 1 deletion packages/side-runtime/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@seleniumhq/side-runtime",
"version": "4.0.0-alpha.30",
"version": "4.0.0-alpha.31",
"private": false,
"description": "Selenium IDE playback and execution",
"author": "Tomer <tomer@corevo.io>",
Expand Down
12 changes: 6 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d1bcee7

Please sign in to comment.