better quit behavior w/r/t drivers

SeleniumHQ · Oct 23, 2023 · de83a31 · de83a31
1 parent 2f8e336
commit de83a31
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/packages/selenium-ide/package.json b/packages/selenium-ide/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@seleniumhq/selenium-ide",
-  "version": "4.0.0-alpha.52",
+  "version": "4.0.0-alpha.53",
   "private": true,
   "description": "Selenium IDE electron app",
   "author": "Todd <tarsitodd@gmail.com>",

diff --git a/packages/selenium-ide/src/main/index.ts b/packages/selenium-ide/src/main/index.ts
@@ -59,6 +59,10 @@ app.on('activate', async () => {
   }
 })
 
+app.on('before-quit', async () => {
+  await session.system.beforeQuit()
+})
+
 app.on('window-all-closed', async () => {
   allWindowsClosed = true
   if (process.platform === 'darwin') {

diff --git a/packages/selenium-ide/src/main/session/controllers/System/index.ts b/packages/selenium-ide/src/main/session/controllers/System/index.ts
@@ -51,9 +51,13 @@ export default class SystemController extends BaseController {
     throw new Error(error)
   }
 
-  async quit() {
+  async beforeQuit() {
     await this.shutdown()
     await this.session.windows.closeAll()
+  }
+
+  async quit() {
+    this.beforeQuit()
     if (this.isDown) {
       this.session.app.quit()
     }