Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium IDE!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Currently, generated Ruby code can't be properly run if it utilizes certain (common) features, namely it tries to invoke
move_to_element
, which is valid in Python's selenium binding, but not ruby's. The correct function is simplymove_to
.RSpec should also be qualified in the top level describe during code generation, or it can cause issues.
Motivation and Context
Generated code is currently broken for Ruby/RSpec.
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
move_to_element
method with the correctmove_to
method for mouse actions.describe
withRSpec
to prevent potential issues.Changes walkthrough 📝
command.js
Fix Ruby mouse action methods in code generation
packages/code-export-ruby-rspec/src/command.js
move_to_element
withmove_to
for Ruby compatibility.index.js
Qualify RSpec describe in Ruby code generation
packages/code-export-ruby-rspec/src/index.js
describe
withRSpec
in Ruby code generation.