-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework sso e2e tests to use playwright vs. jest + playwright #3568
base: master
Are you sure you want to change the base?
Conversation
I'm not sure why Vercel's build is failing, is this related to me?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
The e2e timeout problem seems to persist if I try to run the tests right after spinning up the containers. The test takes more than 30s.
pnpm-lock.yaml
Outdated
@@ -54,20 +50,16 @@ importers: | |||
'@babel/preset-react': 7.16.7_@babel+core@7.17.9 | |||
'@babel/preset-typescript': 7.16.7_@babel+core@7.17.9 | |||
'@parcel/packager-ts': 2.4.1 | |||
'@senecacdot/eslint-config-telescope': 1.1.0_eslint@7.32.0 | |||
'@senecacdot/eslint-config-telescope': link:tools/eslint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you linked the local eslint
config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why it did that? I just used pnpm install
.
@@ -0,0 +1,32 @@ | |||
/* eslint-disable import/no-extraneous-dependencies */ | |||
const { devices } = require('@playwright/test'); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need wait-for-postgres
anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if we needed it, now that we run migrations on the db before the tests? If those work, the db is up, right? I guess I could leave this in anyway, it won't hurt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we could leave it
Failed on #3569 too. |
facebook/react#24304 (comment) This error is caused by the recent incompatible version 18 of The reason why only have this problem on Vercel is probably that we use If that doesn't fix it, we can overrides
|
I've switched Vercel to use |
Rebased onto @DukeManh's test changes for SAML. |
Looks like this is good to go. |
Hi @humphd, It looks like there's a conflict here. Can you resolve it for another round of reviews? Appreciate your work. |
e30dcf6
to
4570717
Compare
@manekenpix I've reworked these tests, updated passport/playwright, etc, which I think might help reduce failures in other PRs. I'll update to pick up your changes to the ci.yml |
e1414ba
to
f57c479
Compare
81a8c11
to
a51adae
Compare
f57c479
to
8894cfb
Compare
8894cfb
to
09e2fb8
Compare
09e2fb8
to
9eef814
Compare
This should be working now, but it's not. I'm going to wait until In the meantime, this updates passport, playwright, supertest to newer in SSO. |
5a81265
to
dd5e15b
Compare
dd5e15b
to
69c1596
Compare
69c1596
to
aef405b
Compare
I've rebased on current
It could be resource limitations, blocking the natural flow of the different containers. Everything works locally for me. |
aef405b
to
1bc341e
Compare
I spent a bunch more time on this, and I'm still stuck. I pass the tests with no issues locally, but my machine is really fast and has a ton of memory. I tried to re-create the VM running in GitHub Actions (2vCPU, 7GiB RAM) and I fail most of the tests. But! The tests do actually run. In GitHub Actions it seems to hang like it's waiting for them to start. Part of me feels like the issue has to be resource contention in an underpowered VM (we have a lot of containers running); but our current e2e tests work, so I'm a bit baffled. Something about how this update runs with playwright is different, and I'm not sure (yet) what it is. I'll have to think more on it. |
Our e2e tests can be flaky. I decided to re-write them to get rid of Jest, and use Playwright directly. When we first started doing this, you had to run playwright via jest; but now that's not needed any more.
This uses turborepo to run the e2e tests. I still need to migrate the parser e2e tests over, which I'll do later. I also need to do some work on the CI side of this. But I wanted to get up what I'd done.
Playwright is such a joy to use, we should write front-end tests with it next.