Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death Squad Update #1887

Merged
merged 55 commits into from
Nov 10, 2024
Merged

Death Squad Update #1887

merged 55 commits into from
Nov 10, 2024

Conversation

EstKemran
Copy link

@EstKemran EstKemran commented Sep 18, 2024

Описание PR

Оружие

  • Цепной меч
  • Пульсовая винтовка
  • Пульсовый дробовик
  • SP-91-RC

Снаряжение

  • Скафандр Командира
  • Скафандр Специалиста
  • Изменить стандартный скафандр ЭС
  • Магнитные ботинки
  • Боевые перчатки ЭС
  • Омни-визор
  • Боевой гипоспрей

Эскадрон смерти

  • Раса ЭС
  • КПК / Должности командира и специалиста
  • Спавнеры

Разное

  • Божественный медипен
  • Турель
  • Частота / Гарнитура
  • Шкафчики командитра и специалиста
  • Новые звуки
  • Локализация

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я ознакомился с наставлением по работе с репозиторием и следовал им при создании PR'а.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения
🆑 Kemran

  • tweak: Обновлён Эскадрон Смерти.

@github-actions github-actions bot added Changes: Sprites Изменение затронуло файлы ".rsu / .png" Changes: Localization Изменение затронуло файлы ".ftl" Changes: Prototypes Изменение затронуло файлы ".yml" кроме неймспейса "maps" labels Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

RSI Diff Bot; head commit 0611651 merging into b3456d4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/SS220/Clothing/Hands/Gloves/dq_gloves.rsi

State Old New Status
equipped-HAND Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/SS220/Clothing/Head/Hardsuits/dq_alpha_helmet.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET Added
off-inhand-left Added
off-inhand-right Added
on-equipped-HELMET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/SS220/Clothing/Head/Hardsuits/dq_helmet_commander.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET Added
off-inhand-left Added
off-inhand-right Added
on-equipped-HELMET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/SS220/Clothing/OuterClothing/Hardsuits/dq_alpha_hardsuit.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/SS220/Clothing/OuterClothing/Hardsuits/dq_hardsuit_commander.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/SS220/Clothing/Shoes/Boots/dq_magboots.rsi

State Old New Status
equipped-FEET Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added
on-equipped-FEET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/SS220/Interface/Misc/job_icons.rsi

State Old New Status
deathsquad Added
deathsquadalpha Added
deathsquadleader Added

Resources/Textures/SS220/Objects/Specific/Medical/medipen.rsi

State Old New Status
holypen Added
holypen_empty Added
medipen-inhand-left Added
medipen-inhand-right Added

Resources/Textures/SS220/Objects/Weapons/Guns/Ammunition/Magazine/Magnum/sp-91.rsi

State Old New Status
base Added
mag-1 Added
mag-2 Added

Resources/Textures/SS220/Objects/Weapons/Guns/Projectiles/redprojectile.rsi

State Old New Status
greenlaser Added

Resources/Textures/SS220/Objects/Weapons/Guns/pulse_shotgun.rsi

State Old New Status
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
heal-mag-unshaded-1 Added
heal-mag-unshaded-2 Added
heal-mag-unshaded-3 Added
heal-mag-unshaded-4 Added
icon Added
inhand-left Added
inhand-right Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/SS220/Objects/Weapons/Guns/sp-91.rsi

State Old New Status
base Added
bolt-open Added
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Resources/Textures/SS220/Objects/Weapons/Melee/chainsword.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/SS220/Structures/Storage/closet.rsi

State Old New Status
deathsquadcommander_door Added
deathsquadspecialist_door Added

Edit: diff updated after 0611651

@EstKemran EstKemran changed the title Death squad Death Squad Update Sep 18, 2024
@github-actions github-actions bot added the Merge Conflict Some content has conflicts. label Sep 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Some content has conflicts. label Sep 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Some content has conflicts. label Sep 21, 2024
@github-actions github-actions bot removed the Merge Conflict Some content has conflicts. label Sep 21, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Some content has conflicts. label Sep 25, 2024
EstKemran and others added 13 commits October 21, 2024 20:08
Co-authored-by: Ady4ik <141335742+Ady4ik@users.noreply.github.com>
Co-authored-by: Ady4ik <141335742+Ady4ik@users.noreply.github.com>
…fic/medical/hypospray.ftl

Co-authored-by: Ady4ik <141335742+Ady4ik@users.noreply.github.com>
…n_cards.yml

Co-authored-by: Ady4ik <141335742+Ady4ik@users.noreply.github.com>
Co-authored-by: Ady4ik <141335742+Ady4ik@users.noreply.github.com>
…ns/gun/battery.ftl

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…ns/gun/battery.ftl

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…ry/battery_guns.yml

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…dsuits.yml

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…ypospray.yml

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…smgs.yml

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…ry/battery_guns.yml

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
…dsuits.yml

Co-authored-by: Svarshik <96281939+lexaSvarshik@users.noreply.github.com>
@stalengd stalengd self-assigned this Oct 21, 2024
@@ -0,0 +1,6 @@
ent-ClothingBackpackDeathSquadOperativeFilled = { ent-ClothingBackpackDeathSquadFilled }
.desc = { ent-ClothingBackpackDeathSquadFilled.desc }
.suffix = Рюкзак оперативника ЭС, Эскадрон Смерти, Death Squad, ЭС, DQ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут и у остальных предметов действительно нужно так много суффиксов? "Рюкзак оперативника ЭС" это чуть ли не название предмета, и 4 суффикса про то что это эскадрон смерти, одного не хватит?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Рюкзак оперативника ЭС" это чуть ли не название предмета

В названии нет принадлежности к роли. Сокращу

Comment on lines +147 to +153
#todo
# - type: Clothing
# sprite: SS220/Objects/Weapons/Melee/chainsword.rsi
# quickEquip: false
# slots:
# - Back
# - suitStorage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Какой ещё туду?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Его переделать надо, но если я отложу пр до его переработки, пр снова начнёт гнить

{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Created by discord:IAmRasputin#5242",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ссылку на источник может если где-то опубликовано?

Co-authored-by: Stalen <33173619+stalengd@users.noreply.github.com>
@stalengd stalengd added the Need to add Wiki220 Требуется добавить на Wiki/поставить задачу Wikiделам вместе с мёрджем. label Oct 21, 2024
Copy link
Collaborator

@stalengd stalengd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё не все суффиксы

@@ -0,0 +1,3 @@
ent-EmergencyMedipenDQ = божественный медипен
.suffix = Эскадрон Смерти, Death Squad, ЭС, DQ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И тут

@@ -0,0 +1,10 @@
ent-WeaponPulseRifle2 = пульсовая винтовака
.suffix = Винтовка, Эскадрон Смерти, Death Squad, ЭС, DQ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И тут

.suffix = Винтовка, Эскадрон Смерти, Death Squad, ЭС, DQ
.desc = Энергетическая винтовка тяжелого типа, способна аннигилировать любые структуры.
ent-WeaponPulseShotgun = пульсовый дробовик
.suffix = Дробовик, Эскадрон Смерти, Death Squad, ЭС, DQ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И тут

@EstKemran EstKemran requested a review from stalengd November 4, 2024 16:56
@EstKemran
Copy link
Author

EstKemran commented Nov 4, 2024

Осталась одна проблема. ID карта дедов не открывает их ящик по доступу CentralCommandDeathSquad (Доступ запрещён). Потыкал, повтыкал, не понял в чём проблема

@EstKemran
Copy link
Author

@stalengd изображение

@stalengd stalengd merged commit 74581a0 into SerbiaStrong-220:master Nov 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Изменение затронуло файлы ".ftl" Changes: Prototypes Изменение затронуло файлы ".yml" кроме неймспейса "maps" Changes: Sprites Изменение затронуло файлы ".rsu / .png" Need to add Wiki220 Требуется добавить на Wiki/поставить задачу Wikiделам вместе с мёрджем. Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants