Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain/nix: Improve the nix development shells #25031

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Conversation

iniw
Copy link
Contributor

@iniw iniw commented Sep 19, 2024

No description provided.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 19, 2024
@timschumi timschumi self-requested a review September 19, 2024 09:43
@nico
Copy link
Contributor

nico commented Sep 20, 2024

Is the formatting done with some kind of auto formatter?

@iniw
Copy link
Contributor Author

iniw commented Sep 20, 2024

Is the formatting done with some kind of auto formatter?

Yes! It was done by nixfmt under default settings, which is the "official" nix formatter AFAIK.

@timschumi
Copy link
Member

Is the formatting done with some kind of auto formatter?

Yes! It was done by nixfmt under default settings, which is the "official" nix formatter AFAIK.

In this case, please codify the formatter in the file. I as far as I know that works fine for devshells.

PS: I started updating the toolchain file some time ago, but ran into build issues (and therefore never uploaded it). I'll try and dig out the branch to see if everything I ran into additionally has been resolved.

@nico
Copy link
Contributor

nico commented Sep 20, 2024

In this case, please codify the formatter in the file. I as far as I know that works fine for devshells.

Do you think that could happen in a follow-up?

@iniw
Copy link
Contributor Author

iniw commented Sep 20, 2024

Is the formatting done with some kind of auto formatter?

Yes! It was done by nixfmt under default settings, which is the "official" nix formatter AFAIK.

In this case, please codify the formatter in the file. I as far as I know that works fine for devshells.

Done. Not sure how useful being able to do nix fmt is considering that command tries doing very dumb things like recursing down gitignored folders (tho apparently that just got deprecated a couple weeks ago) hunting for nix files but perhaps it's useful to communicate what formatter we're expecting.

flake.nix Show resolved Hide resolved
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@iniw iniw force-pushed the master branch 2 times, most recently from 12f7b53 to ee3bdbf Compare September 21, 2024 17:48
The nixfmt-rfc-style package was used.
This commit adds the following packages:

clang-tools: Contains clangd and clang-format.
prettier
pre-commit
@nico nico merged commit c03be8e into SerenityOS:master Sep 22, 2024
13 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants