Browser: Port browser to GML compilation #25399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Oh yes, one more thing to add that felt kinda wrong. The GML compiler works in a way that prevents forward declaration in widget headers. I wonder if there's anything we can do about that and if that's intended. Widget headers become quite huge because of that. |
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
overriden-sfdd
force-pushed
the
port_browser
branch
from
309d010
to
1355efc
Compare
Browser: Port StorageWidget to GML compilation
overriden-sfdd
force-pushed
the
port_browser
branch
from
1355efc
to
f2b5c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #20518
It ports Browser. I'm open for suggestions regarding refactoring of BrowserTabWidget. It's quite puzzling. I'm not sure the way I did it is the best. Please review carefully.
Additionally, I got confused with all the different initialization functions like
try_create,initialize, andsetup. Do we preferinitializeoversetupnow?