Merge pull request #840 from Sergio0694/dev/remove-analytics-service

Remove analytics service from WinUI sample app

samples/ComputeSharp.SwapChain.WinUI/ViewModels/MainViewModel.cs

@@ -1,10 +1,7 @@
 using System.Collections.Generic;
-using CommunityToolkit.Diagnostics;
 using CommunityToolkit.Mvvm.ComponentModel;
 using CommunityToolkit.Mvvm.Input;
-using ComputeSharp.SwapChain.Core.Constants;
 using ComputeSharp.SwapChain.Core.Enums;
-using ComputeSharp.SwapChain.Core.Services;
 using ComputeSharp.SwapChain.Core.Shaders;
 using ComputeSharp.SwapChain.Core.Shaders.Runners;
 using ComputeSharp.SwapChain.Shaders;
@@ -17,19 +14,11 @@ namespace ComputeSharp.SwapChain.Core.ViewModels;
 /// </summary>
 public sealed partial class MainViewModel : ObservableObject
 {
- /// <summary>
- /// The <see cref="IAnalyticsService"/> instance currently in use.
- /// </summary>
- private readonly IAnalyticsService analyticsService;
-
  /// <summary>
  /// Creates a new <see cref="MainViewModel"/> instance.
  /// </summary>
- public MainViewModel(IAnalyticsService analyticsService)
+ public MainViewModel()
  {
- Guard.IsNotNull(analyticsService);
-
- this.analyticsService = analyticsService;
  this.selectedRenderingMode = RenderingMode.DirectX12;
  this.isVerticalSyncEnabled = true;
  this.isDynamicResolutionEnabled = true;
@@ -157,46 +146,10 @@ private void ToggleRenderingPaused()
  IsRenderingPaused = !IsRenderingPaused;
  }
 
- /// <inheritdoc/>
- partial void OnSelectedRenderingModeChanged(RenderingMode value)
- {
- this.analyticsService.Log(Event.SelectedRenderingModeChanged, (nameof(value), value));
- }
-
- /// <inheritdoc/>
- partial void OnIsVerticalSyncEnabledChanged(bool value)
- {
- this.analyticsService.Log(Event.IsVerticalSyncEnabledChanged, (nameof(value), value));
- }
-
- /// <inheritdoc/>
- partial void OnIsDynamicResolutionEnabledChanged(bool value)
- {
- this.analyticsService.Log(Event.IsDynamicResolutionEnabledChanged, (nameof(value), value));
- }
-
- /// <inheritdoc/>
- partial void OnSelectedResolutionScaleChanged(int value)
- {
- this.analyticsService.Log(Event.SelectedResolutionScaleChanged, (nameof(value), value));
- }
-
  /// <inheritdoc/>
  partial void OnSelectedComputeShaderChanging(ShaderRunnerViewModel? oldValue, ShaderRunnerViewModel newValue)
  {
  oldValue!.IsSelected = false;
  newValue.IsSelected = true;
  }
-
- /// <inheritdoc/>
- partial void OnSelectedComputeShaderChanged(ShaderRunnerViewModel value)
- {
- this.analyticsService.Log(Event.SelectedComputeShaderChanged, (nameof(value.ShaderType), value.ShaderType));
- }
-
- /// <inheritdoc/>
- partial void OnIsRenderingPausedChanged(bool value)
- {
- this.analyticsService.Log(Event.IsRenderingPausedChanged, (nameof(value), value));
- }
 }

samples/ComputeSharp.SwapChain.WinUI/Views/MainWindow.xaml

@@ -9,11 +9,14 @@
  xmlns:enums="using:ComputeSharp.SwapChain.Core.Enums"
  xmlns:media="using:CommunityToolkit.WinUI.UI.Media"
  xmlns:ui="using:CommunityToolkit.WinUI.UI"
- xmlns:viewmodels="using:ComputeSharp.SwapChain.Core.ViewModels"
+ xmlns:viewModels="using:ComputeSharp.SwapChain.Core.ViewModels"
  xmlns:views="using:ComputeSharp.SwapChain.WinUI.Views"
  SizeChanged="Window_SizeChanged">
 
  <Grid x:Name="Root">
+ <Grid.DataContext>
+ <viewModels:MainViewModel x:Name="ViewModel"/>
+ </Grid.DataContext>
  <Grid.Resources>
 
  <!--
@@ -109,7 +112,7 @@
  <ListView.ItemTemplate>
 
  <!-- Shader template -->
- <DataTemplate x:DataType="viewmodels:ShaderRunnerViewModel">
+ <DataTemplate x:DataType="viewModels:ShaderRunnerViewModel">
  <controls:ConstrainedBox
  HorizontalAlignment="Stretch"
  VerticalAlignment="Stretch"

samples/ComputeSharp.SwapChain.WinUI/Views/MainWindow.xaml.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Runtime.CompilerServices;
-using ComputeSharp.SwapChain.Core.Services;
 using ComputeSharp.SwapChain.Core.ViewModels;
 using ComputeSharp.WinUI;
 using Microsoft.UI.Xaml;
@@ -25,15 +24,8 @@ public MainWindow()
  ExtendsContentIntoTitleBar = true;
 
  SetTitleBar(this.TitleBarRectangle);
-
- this.Root.DataContext = new MainViewModel(new DebugAnalyticsService());
  }
 
- /// <summary>
- /// Gets the <see cref="MainViewModel"/> instance for the current view.
- /// </summary>
- public MainViewModel ViewModel => (MainViewModel)this.Root.DataContext;
-
  /// <summary>
  /// Stops all rendering when the application is closing.
  /// </summary>