Add unit tests for new analyzer diagnostics

Sergio0694 · Aug 19, 2024 · 46d311b · 46d311b
1 parent 7c1224c
commit 46d311b
Show file tree

Hide file tree

Showing 4 changed files with 127 additions and 4 deletions.
diff --git a/...Generators/Diagnostics/Analyzers/InvalidGeneratedCanvasEffectPropertyAccessorsAnalyzer.cs b/...Generators/Diagnostics/Analyzers/InvalidGeneratedCanvasEffectPropertyAccessorsAnalyzer.cs
@@ -37,6 +37,12 @@ public override void Initialize(AnalysisContext context)
  return;
  }
 
+ // Skip implementation parts to avoid duplicate errors
+ if (context.Symbol is IPropertySymbol { PartialDefinitionPart: not null })
+ {
+ return;
+ }
+
  // If the property is using [GeneratedCanvasEffectProperty], emit the diagnostic
  if (context.Symbol.TryGetAttributeWithType(generatedCanvasEffectPropertyAttributeSymbol, out AttributeData? generatedCanvasEffectPropertyAttribute))
  {

diff --git a/...ators/Diagnostics/Analyzers/InvalidGeneratedCanvasEffectPropertyContainingTypeAnalyzer.cs b/...ators/Diagnostics/Analyzers/InvalidGeneratedCanvasEffectPropertyContainingTypeAnalyzer.cs
@@ -32,8 +32,8 @@ public override void Initialize(AnalysisContext context)
 
  context.RegisterSymbolAction(context =>
  {
- // Validate that we have a valid containing type
- if (context.Symbol is not IPropertySymbol { ContainingType: { } containingTypeSymbol })
+ // Validate that we have a valid containing type (also skip implementation parts)
+ if (context.Symbol is not IPropertySymbol { ContainingType: { } containingTypeSymbol, PartialDefinitionPart: null })
  {
  return;
  }

diff --git a/...nerators/Diagnostics/Analyzers/InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer.cs b/...nerators/Diagnostics/Analyzers/InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer.cs
@@ -37,8 +37,8 @@ public override void Initialize(AnalysisContext context)
 
  context.RegisterSymbolAction(context =>
  {
- // Ensure that we have some target property to analyze
- if (context.Symbol is not IPropertySymbol propertySymbol)
+ // Ensure that we have some target property to analyze (also skip implementation parts)
+ if (context.Symbol is not IPropertySymbol { PartialDefinitionPart: null } propertySymbol)
  {
  return;
  }

diff --git a/...teSharp.D2D1.WinUI.Tests.SourceGenerators/Test_CanvasEffectPropertyGenerator_Analyzers.cs b/...teSharp.D2D1.WinUI.Tests.SourceGenerators/Test_CanvasEffectPropertyGenerator_Analyzers.cs
@@ -56,4 +56,121 @@ public abstract partial class MyEffect : CanvasEffect
 
  await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyAccessorsAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
  }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_StaticProperty_Warns()
+ {
+ const string source = """
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ [{|CMPSD2DWINUI0003:GeneratedCanvasEffectProperty|}]
+ public static partial int {|CS9248:Number|} { get; set; }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_NotPartialProperty_Warns()
+ {
+ const string source = """
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ [{|CMPSD2DWINUI0004:GeneratedCanvasEffectProperty|}]
+ public int Number { get; set; }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_PartialPropertyWithImplementation_Warns()
+ {
+ const string source = """
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ [{|CMPSD2DWINUI0004:GeneratedCanvasEffectProperty|}]
+ public partial int Number { get; set; }
+
+ public partial int Number { get => 42; set { } }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_PartialPropertyImplementationPart_Warns()
+ {
+ const string source = """
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ public partial int Number { get; set; }
+
+ [{|CMPSD2DWINUI0004:GeneratedCanvasEffectProperty|}]
+ public partial int Number { get => 42; set { } }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_ReturnsByRef_Warns()
+ {
+ const string source = """
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ [{|CMPSD2DWINUI0005:GeneratedCanvasEffectProperty|}]
+ public partial ref int {|CS9248:Number|} { get; {|CS8147:set|}; }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_ReturnsByRefReadonly_Warns()
+ {
+ const string source = """
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ [{|CMPSD2DWINUI0005:GeneratedCanvasEffectProperty|}]
+ public partial ref readonly int {|CS9248:Number|} { get; {|CS8147:set|}; }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
+
+ [TestMethod]
+ public async Task InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer_ReturnsRefStructType_Warns()
+ {
+ const string source = """
+ using System;
+ using ComputeSharp.D2D1.WinUI;
+
+ public abstract partial class MyEffect : CanvasEffect
+ {
+ [{|CMPSD2DWINUI0006:GeneratedCanvasEffectProperty|}]
+ public partial Span<int> {|CS9248:Number|} { get; set; }
+ }
+ """;
+
+ await CSharpAnalyzerWithLanguageVersionTest<InvalidGeneratedCanvasEffectPropertyDeclarationAnalyzer>.VerifyAnalyzerAsync(source, languageVersion: LanguageVersion.Preview);
+ }
 }