New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trimming support for ComputeSharp.D2D1.WinUI and CI test #544

Merged

Sergio0694 merged 2 commits into main from dev/fix-sample-ci

Jul 28, 2023

Owner

Sergio0694 commented Jul 28, 2023

Description

This PR includes the following changes:

Fixes the CI script to correctly fail if any of the published samples fails to run
Adds a workaround to allow ComputeSharp.D2D1.WinUI to work fine with trimming (see IL2026 trim warnings on WinRT.TypeExtensions.GetAuthoringMetadataType(Type) for publish builds microsoft/CsWinRT#1319)

Sergio0694 added 2 commits

July 28, 2023 19:08


Return or throw HRESULTs from published samples

8e66e2d


Add workaround for custom WinRT components with CsWinRT

79bbaa3

See microsoft/CsWinRT#1319

Sergio0694 added bug fix ✅ samples 📚 labels

Sergio0694 merged commit 3a1544a into main

48 checks passed

Sergio0694 deleted the dev/fix-sample-ci branch

July 28, 2023 20:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment