Remove implicitly nullable parameter declarations #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly nullable parameter declarations are deprecated from PHP 8.4 on and will be removed in PHP 9. This PR removes all nullable declarations to keep the code compatible with future PHP versions, with no impact on backward compatibility.
As an alternative to dropping declarations, we could use declarations of the form
(?Matrix $ctm = null)
, but then we would lose compatibility with PHP before 7.1.How to reproduce the issues:
With the patches from this PR, the deprecation warnings are gone.