increase default video title to 2 lines

increased the description, upload date text size, comments title and content text size from 12sp to15sp
ShareASmile · Jun 21, 2024 · 8c0ce88 · 8c0ce88
1 parent 7ed4e55
commit 8c0ce88
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -59,10 +59,10 @@ android {
  archivesBaseName = 'NewPipe_' + System.getProperty('packageSuffix')
  }
  minifyEnabled true
- shrinkResources false // disabled to fix F-Droid's reproducible build
+ shrinkResources true // could be disabled to fix F-Droid's reproducible build
  proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
  archivesBaseName = 'app'
- applicationIdSuffix ".Flora"
+ applicationIdSuffix ".flora"
  resValue "string", "app_name", "NewPipe " + "Flora"
  }
  }
@@ -193,8 +193,6 @@ dependencies {
  // This works thanks to JitPack: https://jitpack.io/
  implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
  implementation 'com.github.ShareASmile:NewPipeExtractor:9f741d54b2'
- //implementation 'com.github.TeamNewPipe:NewPipeExtractor:eb07d70a2ce03bee3cc74fc33b2e4173e1c21436'
-
 
 /** Checkstyle **/
  checkstyle "com.puppycrawl.tools:checkstyle:${checkstyleVersion}"

diff --git a/app/src/main/java/org/schabi/newpipelegacy/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipelegacy/fragments/detail/VideoDetailFragment.java
@@ -598,7 +598,7 @@ private void toggleTitleAndSecondaryControls() {
  VideoPlayerUi.DEFAULT_CONTROLS_DURATION, 180);
  binding.detailSecondaryControlPanel.setVisibility(View.VISIBLE);
  } else {
- binding.detailVideoTitleView.setMaxLines(1);
+ binding.detailVideoTitleView.setMaxLines(2);
  animateRotation(binding.detailToggleSecondaryControlsView,
  VideoPlayerUi.DEFAULT_CONTROLS_DURATION, 0);
  binding.detailSecondaryControlPanel.setVisibility(View.GONE);
@@ -1521,7 +1521,7 @@ public void showLoading() {
  animate(binding.positionView, false, 50);
 
  binding.detailVideoTitleView.setText(title);
- binding.detailVideoTitleView.setMaxLines(1);
+ binding.detailVideoTitleView.setMaxLines(2);
  animate(binding.detailVideoTitleView, true, 0);
 
  binding.detailToggleSecondaryControlsView.setVisibility(View.GONE);

diff --git a/app/src/main/res/layout-large-land/fragment_video_detail.xml b/app/src/main/res/layout-large-land/fragment_video_detail.xml
@@ -185,7 +185,7 @@
  android:layout_height="match_parent"
  android:layout_marginEnd="30dp"
  android:ellipsize="end"
- android:maxLines="1"
+ android:maxLines="2"
  android:paddingTop="12dp"
  android:paddingBottom="8dp"
  android:textAppearance="?android:attr/textAppearanceLarge"

diff --git a/app/src/main/res/layout/fragment_video_detail.xml b/app/src/main/res/layout/fragment_video_detail.xml
@@ -173,7 +173,7 @@
  android:layout_height="match_parent"
  android:layout_marginEnd="30dp"
  android:ellipsize="end"
- android:maxLines="1"
+ android:maxLines="2"
  android:paddingTop="12dp"
  android:paddingBottom="8dp"
  android:textAppearance="?android:attr/textAppearanceLarge"

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -65,8 +65,8 @@
  <dimen name="video_item_detail_likes_text_size">12sp</dimen>
  <dimen name="video_item_detail_uploader_text_size">12sp</dimen>
  <dimen name="video_item_detail_sub_channel_text_size">14sp</dimen>
- <dimen name="video_item_detail_upload_date_text_size">13sp</dimen>
- <dimen name="video_item_detail_description_text_size">13sp</dimen>
+ <dimen name="video_item_detail_upload_date_text_size">15sp</dimen>
+ <dimen name="video_item_detail_description_text_size">15sp</dimen>
  <dimen name="channel_subscribers_text_size">12sp</dimen>
  <dimen name="channel_rss_title_size">12sp</dimen>
  <!-- Elements Size -->
@@ -120,8 +120,8 @@
  <dimen name="file_picker_items_text_size">14sp</dimen>
 
  <!-- Text Size -->
- <dimen name="comment_item_title_text_size">12sp</dimen>
- <dimen name="comment_item_content_text_size">12sp</dimen>
+ <dimen name="comment_item_title_text_size">15sp</dimen>
+ <dimen name="comment_item_content_text_size">15sp</dimen>
 
  <!-- Feed Groups dimensions-->
  <dimen name="feed_group_carousel_start_end_margin">12dp</dimen>