Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Animated Scoreboard not loading on startup #57

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Fix Animated Scoreboard not loading on startup #57

merged 2 commits into from
Aug 5, 2023

Conversation

zNoah-1
Copy link
Contributor

@zNoah-1 zNoah-1 commented Aug 5, 2023

Fixed animated scoreboards not loading on startup and a small issue caused by the fix.

Ran the following tests:

  1. Starting up the plugin with animated scoreboard enabled
  2. Starting up the plugin with animated scoreboard disabled

@zNoah-1
Fix Animated Scoreboard not loading on startup
918afe2 
animateScoreboard boolean was not set in startup
@zNoah-1
Fix error when Animated Scoreboard load on startup
a470465 
The library required for Animated Scoreboard wasn't loaded on initialization
@xism4 xism4 merged commit 9464845 into ShieldCommunity:main Aug 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xism4 xism4 xism4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zNoah-1 @xism4