Ignore some more tsc warnings #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans the DEBUG log a lot as these tsc warnings are of no use for us at all. For: https://shiftleftinc.atlassian.net/browse/SEN-1361
max-leuthaeuser
commented
Aug 2, 2023
| @@ -41,11 +41,7 @@ class VueTranspiler(override val config: Config, override val projectPath: Path) | |||
|
|
|||
| private def nodeOptions(): Map[String, String] = { | |||
| // TODO: keep this until https://github.com/webpack/webpack/issues/14532 is fixed. | |||
| // This hack is not required on MacOS. | |||
There was a problem hiding this comment.
With node v18 on our GH macos runners it apparently is again.
ml86
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans the DEBUG log a lot as these tsc warnings are of no use for us at all.
For: https://shiftleftinc.atlassian.net/browse/SEN-1361