Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 環境変数のSecretManager管理下への切り替え #34

Merged
merged 2 commits into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/deploy-cloudrun-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ jobs:
node-version: '20'
cache: 'pnpm'

- name: create .env file
run: |
echo "${{ secrets.ENV_VARS }}" > .env

- name: Install dependencies and build
run: |
pnpm install
Expand Down Expand Up @@ -78,7 +74,6 @@ jobs:
region: asia-northeast1
service: stg-pr-${{ github.event.number }}
image: asia-northeast1-docker.pkg.dev/lumos-profile-management/main/nuxt3-stg-pr-${{ github.event.number }}:latest
env_vars_file: .env

- name: Make CloudRun accessible
run: |
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/deploy-cloudrun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ jobs:
node-version: '20'
cache: 'pnpm'

- name: create .env file
run: |
echo "${{ secrets.ENV_VARS }}" > .env

- name: Install dependencies and build
run: |
pnpm install
Expand Down
1 change: 0 additions & 1 deletion cloudrun/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ FROM node:20-slim
WORKDIR /app

COPY .output .output
COPY .env .env
COPY package.json package.json

CMD ["npm", "run", "start"]
Expand Down