Optimize enqueueing tasks performance #13
+75
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pior
reviewed
Oct 9, 2024
| @@ -112,8 +114,11 @@ func (r *RDB) Enqueue(ctx context.Context, msg *base.TaskMessage) error { | |||
| if err != nil { | |||
| return errors.E(op, errors.Unknown, fmt.Sprintf("cannot encode message: %v", err)) | |||
| } | |||
| if err := r.client.SAdd(ctx, base.AllQueues, msg.Queue).Err(); err != nil { | |||
| return errors.E(op, errors.Unknown, &errors.RedisCommandError{Command: "sadd", Err: err}) | |||
| if _, ok := r.m.Load(msg.Queue); !ok { | |||
There was a problem hiding this comment.
Maybe this for atomicity:
Suggested change
| if _, ok := r.m.Load(msg.Queue); !ok { | |
| if previous, _ := r.m.Swap(msg.Queue, true); previous == nil { |
Since we have many nodes, we probably don't need to check the error.
pior
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different take than #10
Use a
sync.Mapwhich is optimized for use case of write once, ready many times which is what we have here.If the queue is in the map then skip calling sadd. Otherwise add the queue name to the set. This means on startup, the web clients will add the queue to the set once and then skip the call until next restart.
I don't think there is any issue with that. The set
asynq:queuesis left alone, we don't use it for anything, and nothing is deleting from it. SO it's fine to only try to add to it on startup.The code is also simpler in this PR since we don't have to deal with time expiration.