Do not render Text component if discountMethodHidden #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devisscher
approved these changes
Sep 13, 2023
devisscher
force-pushed
the
fix-method-card-spacing-edit
branch
2 times, most recently
from
96579d3 to
0612d0b
Compare
devisscher
force-pushed
the
fix-method-card-spacing-edit
branch
from
0612d0b to
7c07412
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
In edit mode, the
MethodCardhas incorrect spacing between the discount title and the title label/input. This is because theTextcomponent still consumes space with an empty child. This PR, instead wraps theTextcomponent in the relevant if check.Before:
After:
Reviewers’ hat-rack 🎩
In
src/stories/patterns/MethodCardPattern/MethodCardPattern.tsxadd the following prop, and check storybook:discountMethodHidden={true}Before you deploy