Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update spacing in MethodCard component #175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bolariin
Copy link

What problem is this PR solving?

I noticed an inconsistency with the spacing between the discount type title and the discount class label for the MethodCard component in the native shopify discount

I noticed a difference with spacing between the discount type title and discount class label for the MethodCard component in the native shopify discount MethodCard component and MethodCard component from this package. This pr resolves the inconsistency by updating the spacing to match the native shopify discount MethodCard.

native shopify discount MethodCard
Screenshot 2023-11-13 at 1 06 18 AM

discount app components MethodCard
Screenshot 2023-11-13 at 12 59 54 AM

discount app components MethodCard after change
Screenshot 2023-11-13 at 12 35 22 AM

Reviewers’ hat-rack 🎩

  • yarn storybook
  • review story for MethodCard

Before requesting reviews

Before you deploy

Warning
With every PR, you MUST think through each of the items in the following checklist and check the appropriate ones. This step cannot be overlooked by the PR author or its reviewers. Please remove this warning when you're done.

  • This PR is safe to rollback.
  • I tophatted this change on Storybook.

@bolariin bolariin marked this pull request as ready for review November 13, 2023 06:14
@bolariin
Copy link
Author

I've signed the CLA

@bolariin bolariin force-pushed the fix/method-card-spacing branch from 4c94db7 to ef1822c Compare July 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants