feat: add strategy all to StrategyCard #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| @@ -576,6 +576,10 @@ | |||
| "maximum": { | |||
| "label": "Maximum", | |||
| "helpText": "Only apply the discount that offers the maximum reduction." | |||
| }, | |||
| "all": { | |||
| "label": "All", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Allfor keyDiscountAppComponents.DiscountApplicationStrategyCard.all.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
mathiusj
force-pushed
the
mathiusj/add-strategy-all
branch
from
830dcfb to
d82c300
Compare
hmm good point 🤔 I will look into how to best handle this! |
|
@aeperea @samihibrahim updated UI to conditionally render specific strategies based on discount class: Order = First, Maximum |
mathiusj
force-pushed
the
mathiusj/add-strategy-all
branch
from
3f6893f to
7a043f2
Compare
| const isShipping = discountClass === DiscountClass.Shipping; | ||
|
|
||
| const choices = [ | ||
| ...(isProduct || isOrder |
mathiusj
force-pushed
the
mathiusj/add-strategy-all
branch
from
71ed8bf to
243b4a2
Compare
mathiusj
force-pushed
the
mathiusj/add-strategy-all
branch
from
243b4a2 to
715459f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
closes #179
Reviewers’ hat-rack 🎩
yarn run storybookBefore
After for Product:
After for Shipping:
After for Order:
Before requesting reviews
Before you deploy