Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move strategy to constants #188

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: move strategy to constants #188

merged 1 commit into from
Nov 29, 2023

Conversation

mathiusj
Copy link
Contributor

@mathiusj mathiusj commented Nov 28, 2023 •
edited
Loading

What problem is this PR solving?

moved enum to where it belongs. TIL enum's are constants, or was reminded at least 😆

Reviewers’ hat-rack 🎩

Before requesting reviews

Before you deploy

Warning
With every PR, you MUST think through each of the items in the following checklist and check the appropriate ones. This step cannot be overlooked by the PR author or its reviewers. Please remove this warning when you're done.

  • This PR is safe to rollback.
  • I tophatted this change on Storybook.

@mathiusj mathiusj force-pushed the mathiusj/fix-move-strategy-to-constants branch 3 times, most recently from 5346d2b to 5990de0 Compare November 28, 2023 22:12
@mathiusj mathiusj force-pushed the mathiusj/fix-move-strategy-to-constants branch from 5990de0 to e5467b5 Compare November 28, 2023 22:15
samihibrahim
samihibrahim approved these changes Nov 29, 2023
View reviewed changes
Copy link

@samihibrahim samihibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@mathiusj mathiusj merged commit 0e366a8 into main Nov 29, 2023
4 checks passed
@mathiusj mathiusj deleted the mathiusj/fix-move-strategy-to-constants branch November 29, 2023 05:43
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samihibrahim samihibrahim samihibrahim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiusj @samihibrahim