Support deferred expiration of records and attributes for one-to-many associations #577
Conversation
|
nice looking pretty good so far... Why did you need to add |
| @@ -240,6 +242,24 @@ def with_deferred_parent_expiration | |||
| Thread.current[:idc_parent_records_for_cache_expiry].clear | |||
| end | |||
|
|
|||
| def with_deferred_attribute_expiration | |||
There was a problem hiding this comment.
Is it worth creating a joint method alongside the parent expiry deferral? From the public API's perspective, it's a convenience method and I imagine most clients will want to do both. For our use case we do and it would save us having to nest one within the other!
There was a problem hiding this comment.
I agree it would be nice to collapse those two.
Maybe with_deferred_expiration that calls both with_deferred_parent_expiration and with_deferred_attribute_expiration.
Or with_deferred_expiration(parent: true, attribute: false as a way to control that.
There was a problem hiding this comment.
Agree. I am going to merge the two methods, and test again. 👍
| @@ -240,6 +242,24 @@ def with_deferred_parent_expiration | |||
| Thread.current[:idc_parent_records_for_cache_expiry].clear | |||
| end | |||
|
|
|||
| def with_deferred_attribute_expiration | |||
There was a problem hiding this comment.
I agree it would be nice to collapse those two.
Maybe with_deferred_expiration that calls both with_deferred_parent_expiration and with_deferred_attribute_expiration.
Or with_deferred_expiration(parent: true, attribute: false as a way to control that.
drinkbeer
force-pushed
the
jchen/deferred_expiration
branch
from
80d2148
to
7595790
Compare
Related issues: https://github.com/Shopify/caching-platform/issues/708
delete_multi/write_multi) instead of expire each record in a loopidentity_cache_testin Mysql, achieved it by adding a Rake taskpryas a dependency to the repo