Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating notice for Kubeaudit #594

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Deprecating notice for Kubeaudit #594

merged 2 commits into from
Aug 19, 2024

Conversation

Shariatj
Copy link
Contributor

@Shariatj Shariatj commented Aug 19, 2024 •
edited
Loading

Description

Resolves: #593

Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

github-actions[bot]
github-actions bot reviewed Aug 19, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Please check out our contributing guidelines and sign the CLA.

dani-santos-code
dani-santos-code reviewed Aug 19, 2024
View reviewed changes
.github/ISSUE_TEMPLATE.md
For users looking for alternatives, we recommend transitioning to Kubebench, which offers similar functionality and is actively maintained.

Thank you to the community for your contributions and support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: should we do the same for PR templates? 🤔 https://github.com/Shopify/kubeaudit/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Copy link
Contributor Author

@Shariatj Shariatj Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dani-santos-code thank you for pointing it out, I added this to PR templates now

dani-santos-code
dani-santos-code approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you!

@Shariatj Shariatj merged commit 7cfaffd into main Aug 19, 2024
4 checks passed
@Shariatj Shariatj deleted the deprecation branch August 19, 2024 21:38
@BrewTestBot BrewTestBot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@shane-lawrence shane-lawrence shane-lawrence approved these changes

@dani-santos-code dani-santos-code dani-santos-code approved these changes

Assignees
No one assigned
Labels
readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate kubeaudit
3 participants
@Shariatj @shane-lawrence @dani-santos-code