Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle update rubocop #335

Merged
merged 2 commits into from
Sep 17, 2024
Merged

bundle update rubocop #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19e9649
bundle update rubocop
bslobodin Sep 13, 2024
4c73b8e
fix failing tests
bslobodin Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
source "https://rubygems.org"

gem "pry-byebug", require: false
gem 'rubocop', "~> 0.81.0", require: false
gem 'rubocop', require: false

gemspec
31 changes: 17 additions & 14 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ GEM
irb (1.14.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
jaro_winkler (1.5.6)
json (2.7.2)
language_server-protocol (3.17.0.3)
logger (1.6.1)
loofah (2.22.0)
crass (~> 1.0.2)
Expand Down Expand Up @@ -140,8 +141,8 @@ GEM
racc (~> 1.4)
nokogiri (1.16.7-x86_64-linux)
racc (~> 1.4)
parallel (1.24.0)
parser (3.3.0.5)
parallel (1.26.3)
parser (3.3.5.0)
ast (~> 2.4.1)
racc
pry (0.14.2)
Expand All @@ -152,7 +153,7 @@ GEM
pry (>= 0.13, < 0.15)
psych (5.1.2)
stringio
racc (1.8.0)
racc (1.8.1)
rack (3.1.7)
rack-session (2.0.0)
rack (>= 3.0.0)
Expand Down Expand Up @@ -194,10 +195,9 @@ GEM
rake (13.2.1)
rdoc (6.7.0)
psych (>= 4.0.0)
regexp_parser (2.9.2)
reline (0.5.10)
io-console (~> 0.5)
rexml (3.3.6)
strscan
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
Expand All @@ -211,14 +211,18 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
rubocop (0.81.0)
jaro_winkler (~> 1.5.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 2.7.0.1)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
rexml
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 2.0)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
ruby-progressbar (1.13.0)
securerandom (0.3.1)
simplecov (0.22.0)
Expand All @@ -234,12 +238,11 @@ GEM
sqlite3 (2.0.4-x86_64-darwin)
sqlite3 (2.0.4-x86_64-linux-gnu)
stringio (3.1.1)
strscan (3.1.0)
thor (1.3.2)
timeout (0.4.1)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (1.8.0)
unicode-display_width (2.6.0)
useragent (0.16.10)
webrick (1.8.1)
websocket-driver (0.7.6)
Expand All @@ -261,7 +264,7 @@ DEPENDENCIES
pry-byebug
rails (~> 7.2)
rspec (~> 3.2)
rubocop (~> 0.81.0)
rubocop
shopify-money!
simplecov
sqlite3
Expand Down
14 changes: 7 additions & 7 deletions spec/rubocop/cop/money/missing_currency_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
it 'registers an offense and corrects for Money.new without a currency argument' do
expect_offense(<<~RUBY)
Money.new(1)
^^^^^^^^^^^^ Money is missing currency argument
^^^^^^^^^^^^ Money/MissingCurrency: Money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand All @@ -36,7 +36,7 @@
it 'registers an offense and corrects for Money.new without a currency argument' do
expect_offense(<<~RUBY)
Money.new
^^^^^^^^^ Money is missing currency argument
^^^^^^^^^ Money/MissingCurrency: Money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand All @@ -47,7 +47,7 @@
it 'registers an offense and corrects for Money.from_amount without a currency argument' do
expect_offense(<<~RUBY)
Money.from_amount(1)
^^^^^^^^^^^^^^^^^^^^ Money is missing currency argument
^^^^^^^^^^^^^^^^^^^^ Money/MissingCurrency: Money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand All @@ -64,7 +64,7 @@
it 'registers an offense and corrects for Money.from_cents without a currency argument' do
expect_offense(<<~RUBY)
Money.from_cents(1)
^^^^^^^^^^^^^^^^^^^ Money is missing currency argument
^^^^^^^^^^^^^^^^^^^ Money/MissingCurrency: Money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand All @@ -81,7 +81,7 @@
it 'registers an offense and corrects for to_money without a currency argument' do
expect_offense(<<~RUBY)
'1'.to_money
^^^^^^^^^^^^ to_money is missing currency argument
^^^^^^^^^^^^ Money/MissingCurrency: to_money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand All @@ -92,7 +92,7 @@
it 'registers an offense and corrects for safe navigation to_money without a currency argument' do
expect_offense(<<~RUBY)
item&.to_money
^^^^^^^^^^^^^^ to_money is missing currency argument
^^^^^^^^^^^^^^ Money/MissingCurrency: to_money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand All @@ -109,7 +109,7 @@
it 'registers an offense and corrects for to_money block pass form' do
expect_offense(<<~RUBY)
['1'].map(&:to_money)
^^^^^^^^^^^^^^^^^^^^^ to_money is missing currency argument
^^^^^^^^^^^^^^^^^^^^^ Money/MissingCurrency: to_money is missing currency argument
RUBY

expect_correction(<<~RUBY)
Expand Down
4 changes: 2 additions & 2 deletions spec/rubocop/cop/money/zero_money_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
it 'registers an offense and corrects Money.zero without currency' do
expect_offense(<<~RUBY)
Money.zero
^^^^^^^^^^ Money.zero is removed, use `Money.new(0, Money::NULL_CURRENCY)`.
^^^^^^^^^^ Money/ZeroMoney: Money.zero is removed, use `Money.new(0, Money::NULL_CURRENCY)`.
RUBY

expect_correction(<<~RUBY)
Expand All @@ -23,7 +23,7 @@
it 'registers an offense and corrects Money.zero with currency' do
expect_offense(<<~RUBY)
Money.zero('CAD')
^^^^^^^^^^^^^^^^^ Money.zero is removed, use `Money.new(0, 'CAD')`.
^^^^^^^^^^^^^^^^^ Money/ZeroMoney: Money.zero is removed, use `Money.new(0, 'CAD')`.
RUBY

expect_correction(<<~RUBY)
Expand Down
Loading