[FB] Rename Dry Beans as Dry Legumes #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardotejedorsanz
added
taxonomy-tree-requests
ricardotejedorsanz
requested review from
alokaraju,
tylerrowsell and
ornanatan
|
@tylerrowsell Just bringing to your attention that this includes a renamed attribute and category (with no substantial change), which we should check when importing to Core. |
ornanatan
approved these changes
Oct 7, 2024
|
Oooo! Thank you! |
tylerrowsell
reviewed
Oct 7, 2024
| @@ -5042,24 +5042,24 @@ base_attributes: | |||
| - nut_butter_variety__pistachio | |||
| - nut_butter_variety__walnut | |||
| - id: 1492 | |||
| name: Dry bean variety | |||
| description: Identifies the variety of dry beans used, e.g. chickpeas, black beans | |||
| friendly_id: dry_bean_variety | |||
There was a problem hiding this comment.
We definitely can't change this handle without a mapping. As merchants will have metafields already based on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been flagged that we're missing an appropriate category for Lentils, but our tree does provide a suitable category under Food, Beverages & Tobacco > Food Items > Fruits & Vegetables > Dry Beans. This includes the attribute for dry bean varieties like lentils, chickpeas, and soybeans.
However, the current names can be confusing. Renaming it to a broader term like "dry legumes" would clarify that other products considered pulses also have a suitable match here.