Use prism v0.26.0 #1953
Use prism v0.26.0 #1953
Conversation
andyw8
added
the
server
sorbet/rbi/fix.rbi
Outdated
| @@ -0,0 +1,5 @@ | |||
| module Prism | |||
There was a problem hiding this comment.
Checking with Kevin about this.
| @@ -124,7 +124,7 @@ def extract_document_link(node) | |||
| match = comment.location.slice.match(%r{source://.*#\d+$}) | |||
| return unless match | |||
|
|
|||
| uri = T.cast(URI(T.must(match[0])), URI::Source) | |||
| uri = T.cast(URI(match[0]), URI::Source) | |||
There was a problem hiding this comment.
Sorbet was complaining about the T.must on untyped, but I'm not sure why it wasn't previously.
There was a problem hiding this comment.
(previously it was T.nilable(String).
There was a problem hiding this comment.
I wonder if we should cast location.slice as String instead?
There was a problem hiding this comment.
(@st0012 is investigating the underlying cause).
There was a problem hiding this comment.
This was caused by Tapioca dropping signatures of attr_reader methods (issue). I've opened ruby/prism#2719 to convert them into normal method declarations (which Tapioca does anyway).
I also tested that when generating the rbi file from that branch, this change will not be necessary.
andyw8
added
chore
andyw8
force-pushed
the
andyw8/use-prism-0.26.0
branch
from
2969963
to
f546a24
Compare
| @@ -83,7 +83,9 @@ def assert_corrects_to_expected(diagnostic_code, code_action_title, source, expe | |||
| ) | |||
|
|
|||
| diagnostics = RubyLsp::Requests::Diagnostics.new(global_state, document).perform | |||
| diagnostic = T.must(T.must(diagnostics).find { |d| d.code == diagnostic_code }) | |||
| # The source of the returned attributes may be RuboCop or Prism. Prism diagnostics don't have a code. | |||
There was a problem hiding this comment.
The latest Prism returns an additionanal diagnostic:
#<LanguageServer::Protocol::Interface::Diagnostic:0x000000012d318b88
@attributes=
{:range=>
#<LanguageServer::Protocol::Interface::Range:0x000000012d318d40
@attributes=
{:start=>#<LanguageServer::Protocol::Interface::Position:0x000000012d318f48 @attributes={:line=>0, :character=>0}>,
:end=>#<LanguageServer::Protocol::Interface::Position:0x000000012d318d90 @attributes={:line=>0, :character=>1}>}>,
:severity=>2,
:source=>"Prism",
:message=>"assigned but unused variable - a"}>,
I'm not yet sure if this impacts any other Ruby LSP behaviour.
There was a problem hiding this comment.
It should just surface these warnings as diagnostics, that should be fine.
- Bump PORTREVISION for package change Obtained from: Shopify/ruby-lsp#1953
|
I think we can merge this and update again after the next Prism release? |
| @@ -83,7 +83,9 @@ def assert_corrects_to_expected(diagnostic_code, code_action_title, source, expe | |||
| ) | |||
|
|
|||
| diagnostics = RubyLsp::Requests::Diagnostics.new(global_state, document).perform | |||
| diagnostic = T.must(T.must(diagnostics).find { |d| d.code == diagnostic_code }) | |||
| # The source of the returned attributes may be RuboCop or Prism. Prism diagnostics don't have a code. | |||
There was a problem hiding this comment.
It should just surface these warnings as diagnostics, that should be fine.
andyw8
force-pushed
the
andyw8/use-prism-0.26.0
branch
from
f546a24
to
3f0263c
Compare
|
Something is failing in CI for |
- Bump PORTREVISION for package change Obtained from: Shopify/ruby-lsp#1953
Motivation
Closes #1906