Prevent test suite from modifying contributors' Bundler settings #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
server
|
@natematykiewicz there's 1 failing test. |
|
I just pushed a similar commit over to #2082, since that PR is the one that needed to drop the extension, not this one. |
natematykiewicz
force-pushed
the
bundler_temporary
branch
from
1f1abf0
to
469850f
Compare
andyw8
pushed a commit
that referenced
this pull request
May 29, 2024
* Prevent test suite from modifying contributors' Bundler settings * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I install my gems in
vendor/bundle. While working on #2082, I had to re-configure my bundle path every time I ran the test suite. I realized it was because the test suite was deleting my local bundler config.Implementation
I switched the tests to use
Bundler.settings.temporary. You can read more about it here:https://medium.com/@0xcolby/how-does-bundle-install-work-part-1-87a4349c192a
Automated Tests
Current tests still work.
Manual Tests
I can repeatedly run the test suite without having to set my bundle path to
vendor/bundleevery time.