Add counters to measure branch_stub_hit instances on old ISEQs
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably want to put these counters into |
k0kubun
approved these changes
Sep 12, 2023
casperisfine
approved these changes
Sep 13, 2023
|
Are all the CI failures normal on this branch... ? I uh, should I go ahead and merge anyway? 😅 |
That seem to be my fault: That's the backport of https://bugs.ruby-lang.org/issues/19790, tests were passing on my machine but would clearly need some stabilization on CI. But not a huge deal, if it passes the monolith CI, it's safe enough. |
maximecb
merged commit 3b9476f
into
v3.2.2-pshopify15-experimental1
123 of 167 checks passed
k0kubun
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Add counters to measure branch_stub_hit instances on old ISEQs * Add new counters to DEFAULT_COUNTERS
casperisfine
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Add counters to measure branch_stub_hit instances on old ISEQs * Add new counters to DEFAULT_COUNTERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some counters so we can measure and graph how often we hit branch stubs from old ISEQs on Core and SFR