Merge pull request #1308 from elizasorber/adding_indifferent_access_i…

…ssue_1296 Adding indifferent access
Shopify · Jul 23, 2024 · 38c55af · 38c55af
2 parents 6a74e1e + 39e7e85
commit 38c55af
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ Note: For changes to the API, see https://shopify.dev/changelog?filter=api
 ## Unreleased
 
 - [#1327](https://github.com/Shopify/shopify-api-ruby/pull/1327) Support `?debug=true` parameter in GraphQL client requests
+- [#1308](https://github.com/Shopify/shopify-api-ruby/pull/1308) Support hash_with_indifferent_access when creating REST objects from Shopify responses. Closes #1296
 
 ## 14.4.0
 

diff --git a/lib/shopify_api/rest/base.rb b/lib/shopify_api/rest/base.rb
@@ -2,6 +2,7 @@
 # frozen_string_literal: true
 
 require "active_support/inflector"
+require "active_support/core_ext/hash/indifferent_access"
 
 module ShopifyAPI
   module Rest
@@ -248,7 +249,7 @@ def request(http_method:, operation:, session:, ids: {}, params: {}, body: nil,
         def create_instances_from_response(response:, session:)
           objects = []
 
-          body = T.cast(response.body, T::Hash[String, T.untyped])
+          body = T.cast(response.body, T::Hash[String, T.untyped]).with_indifferent_access
 
           response_names = json_response_body_names
 

diff --git a/sorbet/rbi/shims/hash.rb b/sorbet/rbi/shims/hash.rb
@@ -0,0 +1,3 @@
+class Hash
+  def with_indifferent_access; end
+end