Only catch jwt decode errors and preserve the error message to aid debugging #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nelsonwittwer
approved these changes
Nov 8, 2023
garethson
pushed a commit
to garethson/shopify-api-ruby
that referenced
this pull request
Dec 1, 2023
…enError (Shopify#1207) Co-authored-by: Nelson <nelsonwittwer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small change to change that preserves JWT::DecodeError error messages to aid debugging issues with JWT decoding/validation, in particular an issue where a development machine's clock is a few seconds slower than Shopify server clocks:
Shopify/shopify_app#1214
https://github.com/kirillplatonov/shopify-hotwire-sample/issues/23
How has this been tested?
Existing tests still pass.
Checklist: