Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for Shop#google_apps_login_enabled #1337

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

kirillplatonov
Copy link
Contributor

@kirillplatonov kirillplatonov commented Aug 27, 2024

Description

Fixes #1334

Fixes incorrect type of Shop#google_apps_login_enabled attribute in REST API.

How has this been tested?

This code can be used to reproduce the issue and test the fix:

shop = Shop.last
shopify_shop = shop.with_shopify_session do
  ShopifyAPI::Shop.all.first
end
shop_data = shopify_shop.to_hash
shop_data["google_apps_login_enabled"] = true
loaded_shop = shop.with_shopify_session do
  ShopifyAPI::Shop.new(from_hash: shop_data)
end
loaded_shop.google_apps_login_enabled

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

# Conflicts:
#	CHANGELOG.md
@kirillplatonov
Copy link
Contributor Author

cc @paulomarg

Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense - that field is documented as a nullable boolean 👍

Tested it in an app, and it seems fine.

Thanks!

@paulomarg paulomarg merged commit bd811ca into Shopify:main Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong sorbet type of Shop#google_apps_login_enabled
2 participants