This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Adding ability to use nest objects in the URL #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ability for Shopify API Proxy to work with URLs with nested objects, such as requests for a single asset file from a store.
|
Hey! Here is third PR about QS #90 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability for Shopify API proxy to work with URLs containing nested objects, such as requests for a single asset file from a store. Currently, the API proxy simply drops the nested object.
This is a crazy simple change but will save many a lot of frustration. This changes the package used for stringifying the URL query parameters from the package "querystring" to "qs". The constant which is used for referencing this package retains its name of "querystring"—despite the package changing— for purposes of clarity and code readability.