-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for metafield_namespaces in webhook registration #1745
Conversation
@nelsonwittwer could I get a review here please? |
Nice @fourseven - This would be great! Let's get this shipped! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
I think this branch needs a rebase! You will also need to update the changelog to match the current release. While you are updating that you could add a link to the Shopify.dev docs regarding subscribing to webhooks based on metafield namespaces. |
This is an extension on Shopify/shopify-api-ruby#1186, allowing users of the shopify_app ruby/rails library to register webhooks and expect them to return with metafields back.
Fixes `expected positional hash (…), but received keyword arguments (…)` for those method calls by splatting them into keyword arguments.
Thanks @lizkenyon I've made those changes now. |
What this PR does
This is an extension on Shopify/shopify-api-ruby#1186, allowing users of the shopify_app ruby/rails library to register webhooks and expect them to return with metafields back.
Reviewer's guide to testing
I have updated the tests, as well as installing this into our codebase and testing that the app_uninstalled webhook fires, as well as an order create with metafields.
Things to focus on
expected positional hash (…), but received keyword arguments (…)
for those two lines.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary