Add default value to Configuration.scope parameter to make it optional #1913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
What this PR does
Fixes:
ShopifyApp.configure
if we already declare them on the.toml
config file? #1912Background
The
scope
parameter was required as a part of the legacy OAuth flow (Authorization code grant).ShopifyAPI::Context
setup process, but has been changed to be optional from this PRShopifyApp.configuration
does not have explicit expectation forconfig.scope
to be configured, but it will encounter an error during OAuth from ShopStrategySolution
Making
ShopifyApp.configuration.scope
to have a default value[]
so it can be omitted during setup.How has this been tested?
config.scope
setup in theShopifyApp.configure
methodconfig.scope
values are ignored during installationconfig.scope
values are used during installationChecklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary