Reference to snippet and blocks #677
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswamy
commented
Dec 16, 2024
Comment on lines
+213
to
+231
| // TODO: Fix this; seems very costly | ||
| async function getLiquidFiles(uri: string) { | ||
| const rootUri = await findThemeRootURI(uri); | ||
|
|
||
| const blockFiles = await fs.readDirectory(path.join(rootUri, 'blocks')); | ||
| const sectionFiles = await fs.readDirectory(path.join(rootUri, 'sections')); | ||
| const snippetFiles = await fs.readDirectory(path.join(rootUri, 'snippets')); | ||
|
|
||
| const sources = []; | ||
| for(let [uri, _] of [...blockFiles, ...sectionFiles, ...snippetFiles]) { | ||
| const doc = documentManager.get(uri); | ||
| if (!doc || doc.type !== SourceCodeType.LiquidHtml) { | ||
| continue; | ||
| } | ||
| sources.push(doc); | ||
| } | ||
|
|
||
| return sources; | ||
| } |
There was a problem hiding this comment.
Should we keep a memoized ast for each file and invalidate it on file change? Reading every file when someone looks up references to the variable seems expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Support references for snippets and blocks
What's next? Any followup issues?
Before you deploy
changesetallChecksarray insrc/checks/index.tsyarn buildand committed the updated configuration filestheme-app-extension.ymlconfigchangesetchangeset