Add address1 Regex for remaining countries #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabypancu
commented
Sep 18, 2024
db/data/regions/BE.yml
Outdated
| @@ -31,6 +31,9 @@ format: | |||
| show: "{firstName} {lastName}_{company}_{address1}_{address2}_{zip} {city}_{country}_{phone}" | |||
| format_extended: | |||
| edit: "{country}_{firstName}{lastName}_{company}_{streetName}{streetNumber}_{address2}_{zip}{city}_{phone}" | |||
| address1_regex: | |||
| - "^(?<streetName>[^\\d,]+),? (?<streetNumber>\\d+(?: ?[A-Za-z])?)$" | |||
| - "^(?<streetNumber>\\d+(?: ?[A-Za-z])?),? (?<streetName>[^\\d,]+)$" | |||
There was a problem hiding this comment.
The second pattern matches french addresses, which typically have the street number first
gabypancu
commented
Sep 18, 2024
db/data/regions/CL.yml
Outdated
| @@ -16,6 +16,8 @@ format: | |||
| show: "{firstName} {lastName}_{company}_{address1}_{address2}_{zip} {city}_{province}_{country}_{phone}" | |||
| format_extended: | |||
| edit: "{country}_{firstName}{lastName}_{company}_{streetName}{streetNumber}_{line2}{neighborhood}_{zip}{city}_{province}_{phone}" | |||
| address1_regex: | |||
| - "^(?<streetName>[^\\d,]+(?<!\\s[nN])(?<!\\s[nN]\\.)(?<!\\s[Nn]º)(?<!\\s[nN]úmero)(?<!\\s[Nn]o\\.)(?<!\\s[Nn]o)(?<!\\s#)),? (?<streetNumber>(?:n|N|n\\.|N\\.|Nº|nº|número|Número|no\\.|No\\.|no|No|#)? ?\\d+(?: ?[A-Za-z])?)$" | |||
There was a problem hiding this comment.
Don't allow any street-number-designators in the street name
gabypancu
changed the title
gabypancu
force-pushed
the
regex-parsing-more-countries
branch
from
233adb8
to
1adeb05
Compare
rochlefebvre
approved these changes
Sep 19, 2024
gabypancu
force-pushed
the
regex-parsing-more-countries
branch
from
cb3ee75
to
63acfa2
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Follow up to #281
Adds address1 regex for remaining countries with additional address fields in address1: Belgium, Chile, Mexico, Spain, Brazil, Israel
What approach did you choose and why?
The regexes are as conservative as possible to avoid false matches.
Across the board, we don't match:
What should reviewers focus on?
Can the regex be simplified? Have I overlooked any false/incorrect matches that could occur?
Checklist