Skip to content

Commit

Permalink
feat!: Remove keywordPattern backward compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
Shougo committed Nov 8, 2023
1 parent 4a5ec8e commit 4f19a82
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 19 deletions.
19 changes: 0 additions & 19 deletions denops/ddc/ddc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1162,16 +1162,6 @@ async function callSourceOnEvent(
}

try {
if (source.apiVersion < 5) {
// NOTE: It is for backward compatibility.
// Convert keywordPattern
// deno-lint-ignore-file
options.keywordPattern = await convertKeywordPattern(
denops,
sourceOptions.keywordPattern,
);
}

await source.onEvent({
denops,
context,
Expand Down Expand Up @@ -1245,15 +1235,6 @@ async function callSourceGetCompletePosition(
sourceParams: BaseSourceParams,
): Promise<number> {
try {
if (source.apiVersion < 5) {
// NOTE: It is for backward compatibility.
// Convert keywordPattern
options.keywordPattern = await convertKeywordPattern(
denops,
sourceOptions.keywordPattern,
);
}

return await source.getCompletePosition({
denops,
context,
Expand Down
3 changes: 3 additions & 0 deletions doc/ddc.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1620,6 +1620,9 @@ https://github.com/Shougo/ddc-ui-pum
==============================================================================
COMPATIBILITY *ddc-compatibility*

2023.11.08
* Remove keywordPattern backward compatibility.

2023.07.08
* Vim 9.0.1276+ or neovim 0.8+ is required to support the latest MacVim.

Expand Down

0 comments on commit 4f19a82

Please sign in to comment.